feat: KEEP-310 bundle keeperhub-wallet skill in keeperhub plugin#4
Open
eskp wants to merge 1 commit into
Open
Conversation
Vendors `keeperhub-wallet.skill.md` from `@keeperhub/wallet` v0.1.12 as the plugin's fifth skill, so agents installing the keeperhub plugin also know how to pay for KeeperHub marketplace workflows and any x402 / MPP 402 endpoint -- no longer requires a separate `npx -p @keeperhub/wallet keeperhub-wallet skill install` to surface the skill content. What's NOT included in this version bump: - The `PreToolUse` safety hook still has to be registered in `~/.claude/settings.json` for the wallet to actually transact; the skill content documents the one-time `npx -p @keeperhub/wallet keeperhub-wallet skill install` that does that registration. Folding the hook into a plugin-managed `hooks/` declaration is a follow-up. - Wallet provisioning (`keeperhub-wallet add`) is a separate first-run step and remains the user's responsibility. Files: - plugins/keeperhub/skills/keeperhub-wallet/SKILL.md -- vendored. - plugins/keeperhub/.claude-plugin/plugin.json -- v3.0.0 -> v4.0.0, added "agentic-wallet" + "x402" keywords. - .claude-plugin/marketplace.json -- mirror version bump + keywords. - plugins/keeperhub/README.md -- skill list now includes keeperhub-wallet with the install-once footnote. - plugins/keeperhub/CLAUDE.md -- component count 4 -> 5. - CHANGELOG.md -- 4.0.0 entry. Follow-ups: - Plugin-managed PreToolUse hook (Option A2 from the issue). - KEEP-310 also calls for removing the "(soon)" caveat in keeperhub/docs/ai-tools/agentic-wallet.md -- separate PR in the keeperhub repo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Vendors
keeperhub-wallet.skill.mdfrom@keeperhub/walletv0.1.12 as the plugin's fifth skill. After this lands, an agent that installs the keeperhub plugin will know about the wallet skill (triggers, MCP tools, payment flow) without a separate skill install. Pure plugin content -- no executable code shipped.Linear: https://linear.app/keeperhubapp/issue/KEEP-310
What's in scope (Option A from the issue)
plugins/keeperhub/skills/keeperhub-wallet/SKILL.md-- vendored verbatim from@keeperhub/wallet@0.1.12(agentic-wallet/skill/keeperhub-wallet.skill.md).plugins/keeperhub/.claude-plugin/plugin.json-- version 3.0.0 -> 4.0.0; addedagentic-walletandx402keywords..claude-plugin/marketplace.json-- mirrors the version bump and keyword additions.plugins/keeperhub/README.md-- skill list now includeskeeperhub-walletwith a note about the one-timenpx -p @keeperhub/wallet keeperhub-wallet skill installfor the safety hook.plugins/keeperhub/CLAUDE.md-- component count updated 4 -> 5.CHANGELOG.md-- 4.0.0 entry.What's NOT in scope (deferred follow-ups)
PreToolUsehook (Option A2 from the issue). The skill itself still asks users to runnpx -p @keeperhub/wallet keeperhub-wallet skill installonce to register the safety hook in~/.claude/settings.json. Folding the hook into a plugin-declaredhooks/config so plugin install = full functionality is a worthwhile but bigger change (needs research on Claude Code's plugin-hook spec) and didn't fit this PR.npx -p @keeperhub/wallet keeperhub-wallet addstill has to happen once per host to create the wallet. Could be auto-triggered on first paid-workflow call as a UX improvement."(soon)"caveat indocs/ai-tools/agentic-wallet.md-- that file lives in the keeperhub repo, not here. Separate PR.Vendoring concern (called out in the issue)
The skill content now has two sources of truth (
@keeperhub/walletnpm package and this plugin). On the wallet's next material skill update, this plugin will need a re-vendor commit. The wallet's release workflow could automate this, but for now it's manual.Test plan
plugins/keeperhub/skills/keeperhub-wallet/SKILL.mdmatchesagentic-wallet/skill/keeperhub-wallet.skill.md(vendored verbatim from v0.1.12).plugin.jsonandmarketplace.json.wallet skill installseparately still works (the skill ends up registered twice in different locations; should be idempotent on disk because the filenames differ).